Skip to content

feat(platform): Use sidebar_title for breadcrumbs #13402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

feat(platform): Use sidebar_title for breadcrumbs #13402

merged 1 commit into from
Apr 16, 2025

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 16, 2025

E.g. for this change: #13392

It makes more sense to have the sidebar_title be in the breadcrumbs, than the page title.

@mydea mydea requested review from a team, a-hariti and chargome April 16, 2025 07:44
@mydea mydea self-assigned this Apr 16, 2025
@vercel
Copy link

vercel bot commented Apr 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 7:59am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 7:59am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 16, 2025 7:59am

@codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/En6nVrgb_m8ozcJqe5WNL/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/En6nVrgb_m8ozcJqe5WNL/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/9OLvTZyboEZG-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/9OLvTZyboEZG-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

@mydea mydea merged commit ea03ee4 into master Apr 16, 2025
17 checks passed
@mydea mydea deleted the fn/use-sidebar-title-breadcrumbs branch April 16, 2025 08:37
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
@mydea @bitsandfoxes
feat(platform): Use sidebar_title for breadcrumbs (#13402)
b7544f7
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chargome chargome chargome approved these changes

@a-hariti a-hariti Awaiting requested review from a-hariti

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @chargome